Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Smaato: Add support for app #1767

Merged
merged 3 commits into from
Mar 23, 2021
Merged

Smaato: Add support for app #1767

merged 3 commits into from
Mar 23, 2021

Conversation

el-chuck
Copy link
Contributor

This PR allows the Smaato adapter to send app bid requests to the Smaato bidder endpoint.

@SyntaxNode
Copy link
Contributor

SyntaxNode commented Mar 19, 2021 •
edited
Loading

LGTM. Thank you for expanding test coverage. Are you able to add 2 more supplemental tests for the response.StatusCode == http.StatusNoContent and response.StatusCode == http.StatusBadRequest MakeBids conditions.

@SyntaxNode SyntaxNode self-requested a review March 19, 2021 14:39
@SyntaxNode SyntaxNode self-assigned this Mar 19, 2021
@el-chuck
Copy link
Contributor Author

LGTM. Thank you for expanding test coverage. Are you able to add 2 more supplemental tests for the response.StatusCode == http.StatusNoContent and response.StatusCode == http.StatusBadRequest MakeBids conditions.

sure no problem, i will add them

@SyntaxNode SyntaxNode requested a review from guscarreon March 22, 2021 17:13
@el-chuck el-chuck mentioned this pull request Mar 23, 2021
Closed
guscarreon
guscarreon approved these changes Mar 23, 2021
View reviewed changes
Copy link
Contributor

@guscarreon guscarreon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@guscarreon guscarreon merged commit 8760bae into prebid:master Mar 23, 2021
@el-chuck el-chuck mentioned this pull request Mar 23, 2021
Merged
@RodionOrets RodionOrets mentioned this pull request Apr 12, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@guscarreon guscarreon guscarreon approved these changes

@SyntaxNode SyntaxNode SyntaxNode approved these changes

Assignees

@SyntaxNode SyntaxNode

@guscarreon guscarreon

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@el-chuck @SyntaxNode @guscarreon